Skip to content

Refactored test cases #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vineetbansal merged 25 commits into from
Dec 3, 2024
Merged

Refactored test cases #97

vineetbansal merged 25 commits into from
Dec 3, 2024

Conversation

@anushka255
Copy link
Collaborator

@anushka255 anushka255 commented Nov 25, 2024 •
edited
Loading

  • Refactored test cases to use .npz files mostly.
  • Consolidated tests/data/input and tests/data/output directories to a single one tests/data.
  • Upgraded numpy to be greater than version 2.0.
  • The docs are failing in this PR because, one of the docs dependency squidpy is not compatible with numpy of version greater than 2.0. Removed squidpy as docs dependency; using scanpy instead #99 deals with this issue.

anushka255 and others added 21 commits November 22, 2024 16:17
@anushka255
regenerated test file for test_align
0412f43
@anushka255
regenerated test file for test_model_selection
624b635
@anushka255
regenerated test file for test_paste
ff2508b
@anushka255
minor update
c30ace7
@anushka255
regenerated test file for test_paste_2
abb7859
@anushka255
regenerated test file for test_paste_helpers
1c4ae77
@anushka255
regenerated test file for test_visualization
ab6f07e
@anushka255
consolidating test files in a single directory; getting rid of tests/…
c08d407 
…input and tests/output
@anushka255
Merge branch 'main' into aa/refact_test
ee9a567
@anushka255
pre-commit checked
b341bde
@anushka255
fixed docs
d1d737d
@anushka255
added tolerance;
ad64987
@anushka255
lowered tolerance
1547bb4
@anushka255
upgraded numpy
20fb152
@anushka255
upgraded pinned dependencies to latest versions
32f09c3
@anushka255
unpinning some dep
3476c3c
@anushka255
unpinning some dep
f8d603c
@anushka255
unpinning some deps
bf974e7
@anushka255
unpinning some deps
d6eb368
@anushka255
unpinning some deps
3cf3ee5
@anushka255
reverting requirement changes
9e0ac5e
@anushka255 anushka255 changed the title Aa/refact test Refactored test cases Dec 2, 2024
@anushka255 anushka255 marked this pull request as ready for review December 2, 2024 02:18
@vineetbansal
Copy link
Contributor

vineetbansal commented Dec 2, 2024 •
edited
Loading

If I understand correctly, the tests in this PR are passing with numpy<2 (the pinned workflows) and also numpy>2 (unpinned workflows). Given that this is the case, and we're not explicitly using any features exclusive to numpy 2 and above, why don't we just unpin numpy's version from our requirements completely? We should also update our pinned workflows to whatever latest versions seem to be working on the CI.

@anushka255
Copy link
Collaborator Author

anushka255 commented Dec 3, 2024

Unpinned everything in pyproject.toml and updated requirements.txt to pin the latest versions of the packages that work.

@vineetbansal vineetbansal merged commit b6a6020 into main Dec 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anushka255 @vineetbansal